The following document contains the results of FindBugs Report
FindBugs Version is 1.2.1
Threshold is Exp
Effort is Max
| Classes | Bugs | Errors | Missing Classes |
|---|---|---|---|
| 456 | 209 | 0 | 0 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Dead store to resdir in net.charabia.jsmoothgen.pe.PEFile.main(String[]) | STYLE | DLS_DEAD_LOCAL_STORE | 149 |
| Hard coded reference to an absolute pathname in net.charabia.jsmoothgen.pe.PEFile.main(String[]) | STYLE | DMI_HARDCODED_ABSOLUTE_FILENAME | 238 |
| Hard coded reference to an absolute pathname in net.charabia.jsmoothgen.pe.PEFile.main(String[]) | STYLE | DMI_HARDCODED_ABSOLUTE_FILENAME | 124 |
| Hard coded reference to an absolute pathname in net.charabia.jsmoothgen.pe.PEFile.main(String[]) | STYLE | DMI_HARDCODED_ABSOLUTE_FILENAME | 138 |
| PEFile.m_header not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available |
| PEFile.m_oldmsheader not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| Dead store to pemagic in net.charabia.jsmoothgen.pe.PEHeader.read() | STYLE | DLS_DEAD_LOCAL_STORE | 137 |
| Dead store to datasize in net.charabia.jsmoothgen.pe.PEHeader.updateVAAndSize(Vector, Vector) | STYLE | DLS_DEAD_LOCAL_STORE | 383 |
| The field name net.charabia.jsmoothgen.pe.PEHeader.AddressOfEntryPoint doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.PEHeader.BaseOfCode doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.PEHeader.BaseOfData doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.PEHeader.Characteristics doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.PEHeader.CheckSum doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.PEHeader.DllCharacteristics doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.PEHeader.FileAlignment doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.PEHeader.ImageBase doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.PEHeader.LoaderFlags doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.PEHeader.Machine doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.PEHeader.Magic doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.PEHeader.MajorImageVersion doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.PEHeader.MajorLinkerVersion doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.PEHeader.MajorOperatingSystemVersion doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.PEHeader.MajorSubsystemVersion doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.PEHeader.MinorImageVersion doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.PEHeader.MinorLinkerVersion doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.PEHeader.MinorOperatingSystemVersion doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.PEHeader.MinorSubsystemVersion doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.PEHeader.NumberOfRvaAndSizes doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.PEHeader.NumberOfSections doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.PEHeader.NumberOfSymbols doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.PEHeader.PointerToSymbolTable doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.PEHeader.Reserved1 doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.PEHeader.SectionAlignment doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.PEHeader.SizeOfCode doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.PEHeader.SizeOfHeaders doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.PEHeader.SizeOfHeapCommit doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.PEHeader.SizeOfHeapReserve doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.PEHeader.SizeOfImage doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.PEHeader.SizeOfInitializedData doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.PEHeader.SizeOfOptionalHeader doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.PEHeader.SizeOfStackCommit doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.PEHeader.SizeOfStackReserve doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.PEHeader.SizeOfUninitializedData doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.PEHeader.Subsystem doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.PEHeader.TimeDateStamp doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| Useless control flow in net.charabia.jsmoothgen.pe.PEOldMSHeader.read() | STYLE | UCF_USELESS_CONTROL_FLOW | 84 |
| Bug | Category | Details | Line |
|---|---|---|---|
| The field name net.charabia.jsmoothgen.pe.PEResourceDirectory$DataEntry.CodePage doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.PEResourceDirectory$DataEntry.Data doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.PEResourceDirectory$DataEntry.OffsetToData doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.PEResourceDirectory$DataEntry.Reserved doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.PEResourceDirectory$DataEntry.Size doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The class net.charabia.jsmoothgen.pe.PEResourceDirectory$DataEntry could be refactored into a _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_NEEDS_THIS | 64-147 |
| Bug | Category | Details | Line |
|---|---|---|---|
| The field name net.charabia.jsmoothgen.pe.PEResourceDirectory$ImageResourceDirectory.Characteristics doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.PEResourceDirectory$ImageResourceDirectory.IdEntries doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.PEResourceDirectory$ImageResourceDirectory.MajorVersion doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.PEResourceDirectory$ImageResourceDirectory.MinorVersion doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.PEResourceDirectory$ImageResourceDirectory.NamedEntries doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.PEResourceDirectory$ImageResourceDirectory.NumberOfIdEntries doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.PEResourceDirectory$ImageResourceDirectory.NumberOfNamedEntries doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.PEResourceDirectory$ImageResourceDirectory.TimeDateStamp doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The class net.charabia.jsmoothgen.pe.PEResourceDirectory$ImageResourceDirectory could be refactored into a _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_NEEDS_THIS | 353-534 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Dead store to orgchanpos in net.charabia.jsmoothgen.pe.PEResourceDirectory$ResourceEntry.ResourceEntry(PEResourceDirectory, FileChannel) | STYLE | DLS_DEAD_LOCAL_STORE | 189 |
| Dead store to stringoffset in net.charabia.jsmoothgen.pe.PEResourceDirectory$ResourceEntry.buildBuffer(ByteBuffer, long, int) | STYLE | DLS_DEAD_LOCAL_STORE | 296 |
| The field name net.charabia.jsmoothgen.pe.PEResourceDirectory$ResourceEntry.Data doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.PEResourceDirectory$ResourceEntry.Directory doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.PEResourceDirectory$ResourceEntry.Id doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.PEResourceDirectory$ResourceEntry.Name doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| The field name net.charabia.jsmoothgen.pe.PESection.Characteristics doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.PESection.NumberOfLinenumbers doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.PESection.NumberOfRelocations doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.PESection.PointerToLinenumbers doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.PESection.PointerToRawData doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.PESection.PointerToRelocations doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.PESection.SizeOfRawData doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.PESection.VirtualAddress doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.PESection.VirtualSize doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| PESection.ANSI_Name not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| Dead store to bal in net.charabia.jsmoothgen.pe.res.ResIcon.ResIcon(Image) | STYLE | DLS_DEAD_LOCAL_STORE | 215 |
| Dead store to bxl in net.charabia.jsmoothgen.pe.res.ResIcon.ResIcon(Image) | STYLE | DLS_DEAD_LOCAL_STORE | 214 |
| Method net.charabia.jsmoothgen.pe.res.ResIcon.ResIcon(Image) invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 249 |
| Method net.charabia.jsmoothgen.pe.res.ResIcon.calculateColorCount(int[]) invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 283 |
| Method net.charabia.jsmoothgen.pe.res.ResIcon.calculateColorCount(int[]) invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 287 |
| The field name net.charabia.jsmoothgen.pe.res.ResIcon.BitmapAND doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.res.ResIcon.BitmapXOR doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.res.ResIcon.BitsPerPixel doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.res.ResIcon.ColorsImportant doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.res.ResIcon.ColorsUsed doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.res.ResIcon.Compression doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.res.ResIcon.Height doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.res.ResIcon.HorzResolution doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.res.ResIcon.Palette doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.res.ResIcon.Planes doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.res.ResIcon.Size doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.res.ResIcon.SizeOfBitmap doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.res.ResIcon.VertResolution doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.res.ResIcon.Width doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| Private method net.charabia.jsmoothgen.pe.res.ResIcon.getBrightest() is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 261-272 |
| Bug | Category | Details | Line |
|---|---|---|---|
| The field name net.charabia.jsmoothgen.pe.res.ResIcon$PaletteElement.Blue doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.res.ResIcon$PaletteElement.Green doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.res.ResIcon$PaletteElement.Red doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.jsmoothgen.pe.res.ResIcon$PaletteElement.Reserved doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| Should net.charabia.jsmoothgen.pe.res.ResIcon$PaletteElement be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 62-70 |
| Bug | Category | Details | Line |
|---|---|---|---|
| net.charabia.jsmoothgen.pe.res.ResIconDir.getEntries() may expose internal representation by returning ResIconDir.m_entries | MALICIOUS_CODE | EI_EXPOSE_REP | 131 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Dead store to entry in net.charabia.util.codec.IcoCodec.loadImages(File) | STYLE | DLS_DEAD_LOCAL_STORE | 179 |
| Dead store to xorbytes in net.charabia.util.codec.IcoCodec.loadPalettedImage(BinaryInputStream, IcoCodec$IconEntry, IcoCodec$IconHeader, BufferedImage) | STYLE | DLS_DEAD_LOCAL_STORE | 256 |
| Should net.charabia.util.codec.IcoCodec.loadImages(File) return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 220 |
| net.charabia.util.codec.IcoCodec.loadImages(File) ignores result of net.charabia.util.io.BinaryInputStream.skip(long) | BAD_PRACTICE | SR_NOT_CHECKED | 184 |
| Call to swing method in net.charabia.util.codec.IcoCodec.main(String[]) needs to be performed in Swing event thread | BAD_PRACTICE | SW_SWING_METHODS_INVOKED_IN_SWING_THREAD | 344 |
| Call to swing method in net.charabia.util.codec.IcoCodec.main(String[]) needs to be performed in Swing event thread | BAD_PRACTICE | SW_SWING_METHODS_INVOKED_IN_SWING_THREAD | 345 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Unread field: net.charabia.util.codec.IcoCodec$IconEntry.bReserved | PERFORMANCE | URF_UNREAD_FIELD | 69 |
| Bug | Category | Details | Line |
|---|---|---|---|
| The field name net.charabia.util.codec.IcoCodec$IconHeader.BitsPerPixel doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.util.codec.IcoCodec$IconHeader.ColorsImportant doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.util.codec.IcoCodec$IconHeader.ColorsUsed doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.util.codec.IcoCodec$IconHeader.Compression doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.util.codec.IcoCodec$IconHeader.Height doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.util.codec.IcoCodec$IconHeader.HorzResolution doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.util.codec.IcoCodec$IconHeader.Planes doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.util.codec.IcoCodec$IconHeader.Size doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.util.codec.IcoCodec$IconHeader.SizeOfBitmap doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.util.codec.IcoCodec$IconHeader.VertResolution doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| The field name net.charabia.util.codec.IcoCodec$IconHeader.Width doesn't start with an lower case letter | BAD_PRACTICE | NM_FIELD_NAMING_CONVENTION | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| Quantize$Cube.colormap not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| Unread field: net.charabia.util.codec.Quantize$Cube$Search.color_number | PERFORMANCE | URF_UNREAD_FIELD | 667 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Dead store to s in net.sf.ovanttasks.ovanttasks.AbstractStubTask.createWin32Stub(Properties) | STYLE | DLS_DEAD_LOCAL_STORE | 258 |
| Dead store to read in net.sf.ovanttasks.ovanttasks.AbstractStubTask.copy(InputStream, OutputStream) | STYLE | DLS_DEAD_LOCAL_STORE | 127 |
| Dead store of null to ii in net.sf.ovanttasks.ovanttasks.AbstractStubTask.createWin32Stub(Properties) | STYLE | DLS_DEAD_LOCAL_STORE_OF_NULL | 220 |
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 221 |
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 72 |
| net.sf.ovanttasks.ovanttasks.AbstractStubTask.createWin32Stub(Properties) may fail to close stream on exception | BAD_PRACTICE | OS_OPEN_STREAM_EXCEPTION_PATH | 203 |
| Exception is caught when Exception is not thrown in net.sf.ovanttasks.ovanttasks.AbstractStubTask.createWin32Stub(Properties) | STYLE | REC_CATCH_EXCEPTION | 285 |
| net.sf.ovanttasks.ovanttasks.AbstractStubTask.createShellStub(Properties) ignores result of java.io.InputStream.read(byte[], int, int) | BAD_PRACTICE | RR_NOT_CHECKED | 174 |
| net.sf.ovanttasks.ovanttasks.AbstractStubTask.createWin32Stub(Properties) ignores result of java.io.InputStream.read(byte[], int, int) | BAD_PRACTICE | RR_NOT_CHECKED | 254 |
| net.sf.ovanttasks.ovanttasks.AbstractStubTask.createShellStub(Properties) ignores result of java.io.InputStream.read(byte[], int, int) | BAD_PRACTICE | RR_NOT_CHECKED | 153 |
| net.sf.ovanttasks.ovanttasks.AbstractStubTask.createWin32Stub(Properties) ignores result of java.io.InputStream.read(byte[], int, int) | BAD_PRACTICE | RR_NOT_CHECKED | 281 |
| net.sf.ovanttasks.ovanttasks.AbstractStubTask.createWin32Stub(Properties) ignores result of java.io.InputStream.skip(long) | BAD_PRACTICE | SR_NOT_CHECKED | 279 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Field CallTask.target masks field in superclass org.apache.tools.ant.Task | CORRECTNESS | MF_CLASS_MASKS_FIELD | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 174 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Method net.sf.ovanttasks.ovanttasks.CompareTask$1.eval(Comparable, Comparable) invokes toString() method on a String | PERFORMANCE | DM_STRING_TOSTRING | 56 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Method net.sf.ovanttasks.ovanttasks.CompareTask$2.eval(Comparable, Comparable) invokes toString() method on a String | PERFORMANCE | DM_STRING_TOSTRING | 76 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Method net.sf.ovanttasks.ovanttasks.CompareTask$3.eval(Comparable, Comparable) invokes toString() method on a String | PERFORMANCE | DM_STRING_TOSTRING | 94 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Method net.sf.ovanttasks.ovanttasks.CompareTask$4.eval(Comparable, Comparable) invokes toString() method on a String | PERFORMANCE | DM_STRING_TOSTRING | 111 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Method net.sf.ovanttasks.ovanttasks.CompareTask$5.eval(Comparable, Comparable) invokes toString() method on a String | PERFORMANCE | DM_STRING_TOSTRING | 129 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Method net.sf.ovanttasks.ovanttasks.CompareTask$6.eval(Comparable, Comparable) invokes toString() method on a String | PERFORMANCE | DM_STRING_TOSTRING | 147 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Method net.sf.ovanttasks.ovanttasks.JNLPTask.setIndentation(SAXTransformerFactory) invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 1330 |
| Exception is caught when Exception is not thrown in net.sf.ovanttasks.ovanttasks.JNLPTask.execute() | STYLE | REC_CATCH_EXCEPTION | 1323 |
| Bug | Category | Details | Line |
|---|---|---|---|
| The class net.sf.ovanttasks.ovanttasks.JNLPTask$2 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 1301-1315 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Should net.sf.ovanttasks.ovanttasks.JNLPTask$ComponentDesc be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 161-166 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Field only ever set to null: net.sf.ovanttasks.ovanttasks.JNLPTask$Information$Associations.extensions | CORRECTNESS | UWF_NULL_FIELD | 199 |
| Field only ever set to null: net.sf.ovanttasks.ovanttasks.JNLPTask$Information$Associations.mimeType | CORRECTNESS | UWF_NULL_FIELD | 200 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Field only ever set to null: net.sf.ovanttasks.ovanttasks.JNLPTask$Information$RelatedContent.description | CORRECTNESS | UWF_NULL_FIELD | 307 |
| Field only ever set to null: net.sf.ovanttasks.ovanttasks.JNLPTask$Information$RelatedContent.href | CORRECTNESS | UWF_NULL_FIELD | 308 |
| Field only ever set to null: net.sf.ovanttasks.ovanttasks.JNLPTask$Information$RelatedContent.icon | CORRECTNESS | UWF_NULL_FIELD | 309 |
| Field only ever set to null: net.sf.ovanttasks.ovanttasks.JNLPTask$Information$RelatedContent.title | CORRECTNESS | UWF_NULL_FIELD | 310 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Should net.sf.ovanttasks.ovanttasks.JNLPTask$Information$Shortcut$Desktop be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 332-338 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Should net.sf.ovanttasks.ovanttasks.JNLPTask$Security be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 1142-1173 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Should net.sf.ovanttasks.ovanttasks.JNLPTask$Security$Permission be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 1146-1155 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 80 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 318 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Exception is caught when Exception is not thrown in net.sf.ovanttasks.ovanttasks.PreferencesTask$Export.run() | STYLE | REC_CATCH_EXCEPTION | 237 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Confusing to have methods net.sf.ovanttasks.ovanttasks.PreferencesTask$Import.addFileSet(FileSet) and net.sf.ovanttasks.ovanttasks.JNLPTask$Resources$FileResource.addFileset(FileSet) | BAD_PRACTICE | NM_CONFUSING | 155-156 |
| Exception is caught when Exception is not thrown in net.sf.ovanttasks.ovanttasks.PreferencesTask$Import.run() | STYLE | REC_CATCH_EXCEPTION | 187 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Exception is caught when Exception is not thrown in net.sf.ovanttasks.ovanttasks.PreferencesTask$Remove.run() | STYLE | REC_CATCH_EXCEPTION | 602 |
| Bug | Category | Details | Line |
|---|---|---|---|
| net.sf.ovanttasks.ovanttasks.PropertiesTask.execute() may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 226 |
| net.sf.ovanttasks.ovanttasks.PropertiesTask.execute() may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 240 |
| net.sf.ovanttasks.ovanttasks.PropertiesTask.execute() may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 253 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Exception is caught when Exception is not thrown in net.sf.ovanttasks.ovanttasks.PropertiesTask$Property.attach(Properties) | STYLE | REC_CATCH_EXCEPTION | 149 |
| Useless control flow to next line in net.sf.ovanttasks.ovanttasks.PropertiesTask$Property.attach(Properties) | CORRECTNESS | UCF_USELESS_CONTROL_FLOW_NEXT_LINE | 151 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Exception is caught when Exception is not thrown in net.sf.ovanttasks.ovanttasks.SFXTask.createJavaStub() | STYLE | REC_CATCH_EXCEPTION | 51 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 49 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Equals method for net.sf.ovanttasks.ovanttasks.SwitchTask$Case assumes the argument is of type SwitchTask$Case | BAD_PRACTICE | BC_EQUALS_METHOD_SHOULD_WORK_FOR_ALL_OBJECTS | 85 |
| net.sf.ovanttasks.ovanttasks.SwitchTask$Case defines equals and uses Object.hashCode() | BAD_PRACTICE | HE_EQUALS_USE_HASHCODE | 84-88 |
| net.sf.ovanttasks.ovanttasks.SwitchTask$Case.equals(Object) does not check for null argument | BAD_PRACTICE | NP_EQUALS_SHOULD_HANDLE_NULL_ARGUMENT | 86 |
| Should net.sf.ovanttasks.ovanttasks.SwitchTask$Case be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 73-88 |
| SwitchTask$Case.value not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| Exception is caught when Exception is not thrown in net.sf.ovanttasks.ovanttasks.UnixLinkTask.execute() | STYLE | REC_CATCH_EXCEPTION | 43 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Method net.sf.ovanttasks.ovanttasks.Win32RegistryTask.getStringValueOf(Registry, String) uses the same code for two switch clauses | STYLE | DB_DUPLICATE_SWITCH_CLAUSES | 133 |
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 538 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Dead store of null to reg in net.sf.ovanttasks.ovanttasks.Win32RegistryTask$Delete.run() | STYLE | DLS_DEAD_LOCAL_STORE_OF_NULL | 103 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Dead store of null to reg in net.sf.ovanttasks.ovanttasks.Win32RegistryTask$Exists.run() | STYLE | DLS_DEAD_LOCAL_STORE_OF_NULL | 66 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Dead store of null to reg in net.sf.ovanttasks.ovanttasks.Win32RegistryTask$Export.run() | STYLE | DLS_DEAD_LOCAL_STORE_OF_NULL | 299 |
| Exception is caught when Exception is not thrown in net.sf.ovanttasks.ovanttasks.Win32RegistryTask$Export.run() | STYLE | REC_CATCH_EXCEPTION | 329 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Dead store of null to reg in net.sf.ovanttasks.ovanttasks.Win32RegistryTask$Get.run() | STYLE | DLS_DEAD_LOCAL_STORE_OF_NULL | 202 |
| Method net.sf.ovanttasks.ovanttasks.Win32RegistryTask$Get.run() invokes toString() method on a String | PERFORMANCE | DM_STRING_TOSTRING | 215 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Dead store of null to reg in net.sf.ovanttasks.ovanttasks.Win32RegistryTask$Import.run() | STYLE | DLS_DEAD_LOCAL_STORE_OF_NULL | 386 |
| Exception is caught when Exception is not thrown in net.sf.ovanttasks.ovanttasks.Win32RegistryTask$Import.run() | STYLE | REC_CATCH_EXCEPTION | 403 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Dead store of null to reg in net.sf.ovanttasks.ovanttasks.Win32RegistryTask$Set.run() | STYLE | DLS_DEAD_LOCAL_STORE_OF_NULL | 265 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Dead store of null to ii in net.sf.ovanttasks.ovanttasks.Win32ReplaceIconTask.execute() | STYLE | DLS_DEAD_LOCAL_STORE_OF_NULL | 52 |
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 53 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 70 |
| Exception is caught when Exception is not thrown in net.sf.ovanttasks.ovanttasks.Win32ShortcutTask.execute() | STYLE | REC_CATCH_EXCEPTION | 228 |
| Bug | Category | Details | Line |
|---|---|---|---|
| net.sf.ovanttasks.ovanttasks.WriteFileTask.execute() may fail to close stream on exception | BAD_PRACTICE | OS_OPEN_STREAM_EXCEPTION_PATH | 81 |
| net.sf.ovanttasks.ovanttasks.WriteFileTask.execute() may fail to close stream on exception | BAD_PRACTICE | OS_OPEN_STREAM_EXCEPTION_PATH | 99 |
| net.sf.ovanttasks.ovanttasks.WriteFileTask.setSrc(File) may fail to close stream on exception | BAD_PRACTICE | OS_OPEN_STREAM_EXCEPTION_PATH | 34 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Field only ever set to null: net.sf.ovanttasks.ovanttasks.http.Hostname.property | CORRECTNESS | UWF_NULL_FIELD | 27 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Dead store to timestamp in net.sf.ovanttasks.ovanttasks.http.HttpTask.getTimestamp() | STYLE | DLS_DEAD_LOCAL_STORE | 670 |
| Dead store of null to is in net.sf.ovanttasks.ovanttasks.http.HttpTask.execute() | STYLE | DLS_DEAD_LOCAL_STORE_OF_NULL | 556 |
| Dead store of null to out in net.sf.ovanttasks.ovanttasks.http.HttpTask.execute() | STYLE | DLS_DEAD_LOCAL_STORE_OF_NULL | 501 |
| Comparison of String objects using == or != in net.sf.ovanttasks.ovanttasks.http.HttpTask.setUseTimestamp(boolean) | BAD_PRACTICE | ES_COMPARING_STRINGS_WITH_EQ | 227 |
| net.sf.ovanttasks.ovanttasks.http.HttpTask.execute() may fail to close stream on exception | BAD_PRACTICE | OS_OPEN_STREAM_EXCEPTION_PATH | 504 |
| net.sf.ovanttasks.ovanttasks.http.HttpTask.execute() may fail to close stream on exception | BAD_PRACTICE | OS_OPEN_STREAM_EXCEPTION_PATH | 515 |
| HttpTask.source not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| Comparison of String objects using == or != in net.sf.ovanttasks.ovanttasks.http.SetProxy.applyWebProxySettings() | BAD_PRACTICE | ES_COMPARING_STRINGS_WITH_EQ | 143 |
| Bug | Category | Details | Line |
|---|---|---|---|
| net.sf.ovanttasks.ovanttasks.stub.alert(String) invokes System.exit(...), which shuts down the entire virtual machine | BAD_PRACTICE | DM_EXIT | 252 |
| The class name net.sf.ovanttasks.ovanttasks.stub doesn't start with an upper case letter | BAD_PRACTICE | NM_CLASS_NAMING_CONVENTION | 36-253 |
| net.sf.ovanttasks.ovanttasks.stub.unjar(String, String[]) may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 184 |
| net.sf.ovanttasks.ovanttasks.stub.writeEntry(JarFile, JarEntry) may fail to close stream on exception | BAD_PRACTICE | OS_OPEN_STREAM_EXCEPTION_PATH | 218 |
| net.sf.ovanttasks.ovanttasks.stub.writeEntry(JarFile, JarEntry) may fail to close stream on exception | BAD_PRACTICE | OS_OPEN_STREAM_EXCEPTION_PATH | 219 |
| Exception is caught when Exception is not thrown in net.sf.ovanttasks.ovanttasks.stub.writeEntry(JarFile, JarEntry) | STYLE | REC_CATCH_EXCEPTION | 236 |
| Exception is caught when Exception is not thrown in net.sf.ovanttasks.ovanttasks.stub.unjar(String, String[]) | STYLE | REC_CATCH_EXCEPTION | 192 |
